[#162,be/csv][s]: add fetch method as per new #162 approach and support more methods than just file - string, local online CSV file.

* Also get to remove code obsoleted by recent work in #165 to allow fetch to return simple set of records (see penultimate commit)

src/backend/csv.js

@@ -3,59 +3,50 @@ this.recline.Backend = this.recline.Backend || {};
 this.recline.Backend.CSV = this.recline.Backend.CSV || {};
 
 (function(my) {
-  my.fetch = function(dataset) {
+  // ## fetch
+  //
   // 3 options
   //
-    // 1. CSV local fileobject -> HTML5 file object + CSV reader
+  // 1. CSV local fileobject -> HTML5 file object + CSV parser
+  // 2. Already have CSV string (in data) attribute -> CSV parser
   // 2. online CSV file that is ajax-able -> ajax + csv parser
-    // 3. remote file (CSV or XLS) or XLS -> dataproxy
   //
   // All options generates similar data and give a memory store outcome
-
+  my.fetch = function(dataset) {
-  };
+    var dfd = $.Deferred();
-
+    if (dataset.file) {
-  // ## load
-  //
-  // Load data from a CSV file referenced in an HTMl5 file object returning the
-  // dataset in the callback
-  //
-  // @param options as for parseCSV below
-  my.load = function(file, callback, options) {
-    var encoding = options.encoding || 'UTF-8';
-    
-    var metadata = {
-      id: file.name,
-      file: file
-    };
       var reader = new FileReader();
-    // TODO
+      var encoding = dataset.encoding || 'UTF-8';
       reader.onload = function(e) {
-      var dataset = my.csvToDataset(e.target.result, options);
+        var rows = my.parseCSV(e.target.result, dataset);
-      callback(dataset);
+        dfd.resolve({
+          records: rows,
+          metadata: {
+            filename: dataset.file.name
+          },
+          useMemoryStore: true
+        });
       };
       reader.onerror = function (e) {
         alert('Failed to load file. Code: ' + e.target.error.code);
       };
       reader.readAsText(file, encoding);
-  };
+    } else if (dataset.data) {
-
+      var rows = my.parseCSV(dataset.data, dataset);
-  my.csvToDataset = function(csvString, options) {
+      dfd.resolve({
-    var out = my.parseCSV(csvString, options);
+        records: rows,
-    fields = _.map(out[0], function(cell) {
+        useMemoryStore: true
-      return { id: cell, label: cell };
       });
-    var data = _.map(out.slice(1), function(row) {
+    } else if (dataset.url) {
-      var _doc = {};
+      $.get(dataset.url).done(function(data) {
-      _.each(out[0], function(fieldId, idx) {
+        var rows = my.parseCSV(dataset.data, dataset);
-        _doc[fieldId] = row[idx];
+        dfd.resolve({
+          records: rows,
+          useMemoryStore: true
         });
-      return _doc;
       });
-    var dataset = new recline.Model.Dataset({
+    }
-      records: data,
+    return dfd.promise();
-      fields: fields
-    });
-    return dataset;
   };
 
   // Converts a Comma Separated Values string into an array of arrays.
@@ -71,17 +62,16 @@ this.recline.Backend.CSV = this.recline.Backend.CSV || {};
   // 	@param {Boolean} [trim=false] If set to True leading and trailing whitespace is stripped off of each non-quoted field as it is imported
   //	@param {String} [separator=','] Separator for CSV file
   // Heavily based on uselesscode's JS CSV parser (MIT Licensed):
-  // thttp://www.uselesscode.org/javascript/csv/
+  // http://www.uselesscode.org/javascript/csv/
   my.parseCSV= function(s, options) {
     // Get rid of any trailing \n
     s = chomp(s);
 
     var options = options || {};
-    var trm = options.trim;
+    var trm = (options.trim === false) ? false : true;
     var separator = options.separator || ',';
     var delimiter = options.delimiter || '"';
 
-
     var cur = '', // The character we are currently processing.
       inQuote = false,
       fieldQuoted = false,

test/backend/csv.test.js

@@ -24,9 +24,15 @@ test("parseCSV", function() {
   '"Jones, Jay", 10\n' +
   '"Xyz ""ABC"" O\'Brien", 11:35\n' +
   '"Other, AN", 12:35\n';
-  var dataset = recline.Backend.CSV.csvToDataset(csv);
+  var dataset = new recline.Model.Dataset({
-  dataset.query();
+      data: csv
+    },
+    'csv'
+  );
+  dataset.fetch();
   equal(dataset.currentRecords.length, 3);
+  var row = dataset.currentRecords.models[0].toJSON();
+  deepEqual(row, {Name: 'Jones, Jay', Value: 10});
 });
 
 test("parseCSVsemicolon", function() {