knight/datahub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only create variables if we need them.

Browse Source
This commit is contained in:
David Miller
2013-08-06 18:26:12 +01:00
parent c34d8c681c
commit 49d89cc0ea
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/view.flot.js
View File

@@ -313,8 +313,6 @@ my.Flot = Backbone.View.extend({
var points = []; var points = [];
var fieldLabel = self.model.fields.get(field).get('label'); var fieldLabel = self.model.fields.get(field).get('label');
var raw = _.map(self.model.records.models, function(doc, index){ return doc.getFieldValueUnrendered(xfield) });
if (isDateTime){ if (isDateTime){
var cast = function(x){ var cast = function(x){
var _date = moment(String(x)); var _date = moment(String(x));
@@ -323,11 +321,18 @@ my.Flot = Backbone.View.extend({
} }
return x return x
} }
} else if (_.all(raw, function(x){ return !isNaN(parseFloat(x)) })){ } else {
var raw = _.map(self.model.records.models,
function(doc, index){
return doc.getFieldValueUnrendered(xfield)
});
if (_.all(raw, function(x){ return !isNaN(parseFloat(x)) })){
var cast = function(x){ return parseFloat(x) } var cast = function(x){ return parseFloat(x) }
} else { } else {
self.xvaluesAreIndex = true self.xvaluesAreIndex = true
} }
}
_.each(self.model.records.models, function(doc, index) { _.each(self.model.records.models, function(doc, index) {
if(self.xvaluesAreIndex){ if(self.xvaluesAreIndex){