knight/datahub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[tidying][xs]: comment out unused showDialog method and add some TODO comments about unconverted old recline methods.

Browse Source
This commit is contained in:
Rufus Pollock
2012-01-06 13:32:00 +00:00
parent 08d256816f
commit 587a4fc3b9
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/view.js
View File

@@ -123,15 +123,16 @@ my.DataTable = Backbone.View.extend({
'click .row-header-menu': 'onRowHeaderClick' 'click .row-header-menu': 'onRowHeaderClick'
}, },
showDialog: function(template, data) { // TODO: delete or re-enable (currently this code is not used from anywhere except deprecated or disabled methods (see above)).
if (!data) data = {}; // showDialog: function(template, data) {
util.show('dialog'); // if (!data) data = {};
util.render(template, 'dialog-content', data); // util.show('dialog');
util.observeExit($('.dialog-content'), function() { // util.render(template, 'dialog-content', data);
util.hide('dialog'); // util.observeExit($('.dialog-content'), function() {
}) // util.hide('dialog');
$('.dialog').draggable({ handle: '.dialog-header', cursor: 'move' }); // })
}, // $('.dialog').draggable({ handle: '.dialog-header', cursor: 'move' });
// },
// ====================================================== // ======================================================
@@ -155,11 +156,13 @@ my.DataTable = Backbone.View.extend({
var actions = { var actions = {
bulkEdit: function() { self.showTransformColumnDialog('bulkEdit', {name: self.state.currentColumn}) }, bulkEdit: function() { self.showTransformColumnDialog('bulkEdit', {name: self.state.currentColumn}) },
transform: function() { self.showTransformDialog('transform') }, transform: function() { self.showTransformDialog('transform') },
// TODO: Delete or re-implement ...
csv: function() { window.location.href = app.csvUrl }, csv: function() { window.location.href = app.csvUrl },
json: function() { window.location.href = "_rewrite/api/json" }, json: function() { window.location.href = "_rewrite/api/json" },
urlImport: function() { showDialog('urlImport') }, urlImport: function() { showDialog('urlImport') },
pasteImport: function() { showDialog('pasteImport') }, pasteImport: function() { showDialog('pasteImport') },
uploadImport: function() { showDialog('uploadImport') }, uploadImport: function() { showDialog('uploadImport') },
// END TODO
deleteColumn: function() { deleteColumn: function() {
var msg = "Are you sure? This will delete '" + self.state.currentColumn + "' from all documents."; var msg = "Are you sure? This will delete '" + self.state.currentColumn + "' from all documents.";
// TODO: // TODO: