From 81167e39fe6079b4d94e1d496ce46357cd106ed8 Mon Sep 17 00:00:00 2001
From: Rufus Pollock <rufus.pollock@okfn.org>
Date: Sat, 16 Jun 2012 16:46:34 +0100
Subject: [PATCH] [#154,filtereditor][s]: refactor how we lay out the filters
 in order to group inputs for a given filter together more.

* Model.Query: use distance_unit for geo_distance filter.
---
 src/model.js               |  3 ++-
 src/widget.filtereditor.js | 37 ++++++++++++++++++++++---------------
 2 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/src/model.js b/src/model.js
index 74031b3f..3bf80a6b 100644
--- a/src/model.js
+++ b/src/model.js
@@ -423,7 +423,8 @@ my.Query = Backbone.Model.extend({
       term: ''
     },
     geo_distance: {
-      distance: '10km',
+      distance: 10,
+      distance_unit: 'km',
       point: {
         lon: 0,
         lat: 0
diff --git a/src/widget.filtereditor.js b/src/widget.filtereditor.js
index 3fa58010..4ae2eafd 100644
--- a/src/widget.filtereditor.js
+++ b/src/widget.filtereditor.js
@@ -39,23 +39,30 @@ my.FilterEditor = Backbone.View.extend({
   ',
   filterTemplates: {
     term: ' \
-      <div class="control-group filter-{{type}} filter"> \
-        <label class="control-label" for="">{{field}}</label> \
-        <div class="controls"> \
-            <input type="text" value="{{term}}" name="term" data-filter-field="{{field}}" data-filter-id="{{id}}" data-filter-type="{{type}}" /> \
-            <a class="js-remove-filter" href="#">&times;</a> \
-        </div> \
+      <div class="filter-{{type}} filter"> \
+        <fieldset> \
+          <legend> \
+            {{field}} <small>{{type}}</small> \
+            <a class="js-remove-filter" href="#" title="Remove this filter">&times;</a> \
+          </legend> \
+          <input type="text" value="{{term}}" name="term" data-filter-field="{{field}}" data-filter-id="{{id}}" data-filter-type="{{type}}" /> \
+        </fieldset> \
       </div> \
     ',
     geo_distance: ' \
-      <div class="control-group filter-{{type}} filter"> \
-        <label class="control-label" for="">{{field}}</label> \
-        <a class="js-remove-filter" href="#">&times;</a> \
-        <div class="controls"> \
-            <input type="text" value="{{point.lon}}" name="lon" data-filter-field="{{field}}" data-filter-id="{{id}}" data-filter-type="{{type}}" /> \
-            <input type="text" value="{{point.lat}}" name="lat" data-filter-field="{{field}}" data-filter-id="{{id}}" data-filter-type="{{type}}" /> \
-            <input type="text" value="{{distance}}" name="distance" data-filter-field="{{field}}" data-filter-id="{{id}}" data-filter-type="{{type}}" /> \
-        </div> \
+      <div class="filter-{{type}} filter"> \
+        <fieldset> \
+          <legend> \
+            {{field}} <small>{{type}}</small> \
+            <a class="js-remove-filter" href="#" title="Remove this filter">&times;</a> \
+          </legend> \
+          <label class="control-label" for="">Longitude</label> \
+          <input type="text" value="{{point.lon}}" name="lon" data-filter-field="{{field}}" data-filter-id="{{id}}" data-filter-type="{{type}}" /> \
+          <label class="control-label" for="">Latitude</label> \
+          <input type="text" value="{{point.lat}}" name="lat" data-filter-field="{{field}}" data-filter-id="{{id}}" data-filter-type="{{type}}" /> \
+          <label class="control-label" for="">Distance (km)</label> \
+          <input type="text" value="{{distance}}" name="distance" data-filter-field="{{field}}" data-filter-id="{{id}}" data-filter-type="{{type}}" /> \
+        </fieldset> \
       </div> \
     '
   },
@@ -126,7 +133,7 @@ my.FilterEditor = Backbone.View.extend({
         filters[filterIndex].term = value;
       } else if (filterType === 'geo_distance') {
         if (name === 'distance') {
-          filters[filterIndex].distance = parseInt(value);
+          filters[filterIndex].distance = parseFloat(value);
         } else {
           filters[filterIndex].point[name] = parseFloat(value);
         }