From a3ad4a834e57b3bb8c68093f5a00cda96fc2552e Mon Sep 17 00:00:00 2001 From: Rufus Pollock Date: Sat, 16 Jun 2012 18:00:23 +0100 Subject: [PATCH 1/3] [multiview][xs]: show filter editor in sidebar by default. --- src/view.multiview.js | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/view.multiview.js b/src/view.multiview.js index 1401dc36..f6f669e4 100644 --- a/src/view.multiview.js +++ b/src/view.multiview.js @@ -87,7 +87,7 @@ my.MultiView = Backbone.View.extend({ \ \ @@ -228,12 +228,6 @@ my.MultiView = Backbone.View.extend({ }); this.$filterEditor = filterEditor.el; $dataSidebar.append(filterEditor.el); - // are there actually any filters to show? - if (this.model.get('filters') && this.model.get('filters').length > 0) { - this.$filterEditor.show(); - } else { - this.$filterEditor.hide(); - } var fieldsView = new recline.View.Fields({ model: this.model From 92b061ef00e7b2d34800c053a559427669459da4 Mon Sep 17 00:00:00 2001 From: Rufus Pollock Date: Sat, 16 Jun 2012 18:00:53 +0100 Subject: [PATCH 2/3] [map,bugfix][xs]: tick / untick autozoom control correctly. --- src/view.map.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/view.map.js b/src/view.map.js index 006887f4..daa27f96 100644 --- a/src/view.map.js +++ b/src/view.map.js @@ -448,7 +448,7 @@ my.MapMenu = Backbone.View.extend({ events: { 'click .editor-update-map': 'onEditorSubmit', 'change .editor-field-type': 'onFieldTypeChange', - 'change #editor-auto-zoom': 'onAutoZoomChange' + 'click #editor-auto-zoom': 'onAutoZoomChange' }, initialize: function(options) { @@ -472,13 +472,19 @@ my.MapMenu = Backbone.View.extend({ if (this._geomReady() && this.model.fields.length){ if (this.state.get('geomField')){ this._selectOption('editor-geom-field',this.state.get('geomField')); - $('#editor-field-type-geom').attr('checked','checked').change(); + this.el.find('#editor-field-type-geom').attr('checked','checked').change(); } else{ this._selectOption('editor-lon-field',this.state.get('lonField')); this._selectOption('editor-lat-field',this.state.get('latField')); - $('#editor-field-type-latlon').attr('checked','checked').change(); + this.el.find('#editor-field-type-latlon').attr('checked','checked').change(); } } + if (this.state.get('autoZoom')) { + this.el.find('#editor-auto-zoom').attr('checked', 'checked'); + } + else { + this.el.find('#editor-auto-zoom').removeAttr('checked'); + } return this; }, From b64daea1a763ba40d450d8234f7b3ac0c8f15c16 Mon Sep 17 00:00:00 2001 From: Rufus Pollock Date: Sat, 16 Jun 2012 18:27:59 +0100 Subject: [PATCH 3/3] [#111,elasticsearch,geofilter][xs]: work out that what ES docs describe as distance_unit field is actually called unit. --- src/backend/elasticsearch.js | 1 + src/model.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/elasticsearch.js b/src/backend/elasticsearch.js index 0ed05723..1db060d9 100644 --- a/src/backend/elasticsearch.js +++ b/src/backend/elasticsearch.js @@ -124,6 +124,7 @@ this.recline.Backend.ElasticSearch = this.recline.Backend.ElasticSearch || {}; } else if (filter.type === 'geo_distance') { out.geo_distance[filter.field] = filter.point; out.geo_distance.distance = filter.distance; + out.geo_distance.unit = filter.unit; } return out; }, diff --git a/src/model.js b/src/model.js index 3bf80a6b..ea7a9ff1 100644 --- a/src/model.js +++ b/src/model.js @@ -424,7 +424,7 @@ my.Query = Backbone.Model.extend({ }, geo_distance: { distance: 10, - distance_unit: 'km', + unit: 'km', point: { lon: 0, lat: 0