From 89e7b942aae912230e320c2c241c9c67444a7b9f Mon Sep 17 00:00:00 2001 From: anuveyatsu Date: Sat, 14 Aug 2021 21:07:04 +0600 Subject: [PATCH] [KeyInfo component][xs]: removed complex/buggy logic for calculating total size of all files. We still can display total size if it is available from 'descriptor.size', otherwise, we just display 'N/A'. This is probably a good one for removal in the future as we could show sizes for each resource instead of total size. --- dist/index.cjs.js | 10 +--------- dist/index.esm.js | 10 +--------- src/components/dataset/KeyInfo.js | 11 +---------- 3 files changed, 3 insertions(+), 28 deletions(-) diff --git a/dist/index.cjs.js b/dist/index.cjs.js index 314e3e5f..c1afa8b4 100644 --- a/dist/index.cjs.js +++ b/dist/index.cjs.js @@ -221,14 +221,6 @@ var KeyInfo = function KeyInfo(_ref) { var descriptor = _ref.descriptor, resources = _ref.resources; - var datasetSize = 0; - - if (resources) { - datasetSize = resources.length == 1 ? resources[0].size || 0 : resources.reduce(function (accumulator, currentValue) { - return (accumulator.size || 0) + (currentValue.size || 0); - }); - } - var formats = resources.map(function (item) { return item.format; }).join(', '); @@ -260,7 +252,7 @@ var KeyInfo = function KeyInfo(_ref) { className: "text-1xl" }, resources.length)), /*#__PURE__*/React__default['default'].createElement("div", null, /*#__PURE__*/React__default['default'].createElement("h3", { className: "text-1xl" - }, datasetSize)), /*#__PURE__*/React__default['default'].createElement("div", null, /*#__PURE__*/React__default['default'].createElement("h3", { + }, descriptor.size || 'N/A')), /*#__PURE__*/React__default['default'].createElement("div", null, /*#__PURE__*/React__default['default'].createElement("h3", { className: "text-1xl" }, formats)), /*#__PURE__*/React__default['default'].createElement("div", null, /*#__PURE__*/React__default['default'].createElement("h3", { className: "text-1xl" diff --git a/dist/index.esm.js b/dist/index.esm.js index d87c02ad..ede83498 100644 --- a/dist/index.esm.js +++ b/dist/index.esm.js @@ -187,14 +187,6 @@ var KeyInfo = function KeyInfo(_ref) { var descriptor = _ref.descriptor, resources = _ref.resources; - var datasetSize = 0; - - if (resources) { - datasetSize = resources.length == 1 ? resources[0].size || 0 : resources.reduce(function (accumulator, currentValue) { - return (accumulator.size || 0) + (currentValue.size || 0); - }); - } - var formats = resources.map(function (item) { return item.format; }).join(', '); @@ -226,7 +218,7 @@ var KeyInfo = function KeyInfo(_ref) { className: "text-1xl" }, resources.length)), /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("h3", { className: "text-1xl" - }, datasetSize)), /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("h3", { + }, descriptor.size || 'N/A')), /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("h3", { className: "text-1xl" }, formats)), /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("h3", { className: "text-1xl" diff --git a/src/components/dataset/KeyInfo.js b/src/components/dataset/KeyInfo.js index 147a20d1..3aa4c9e7 100644 --- a/src/components/dataset/KeyInfo.js +++ b/src/components/dataset/KeyInfo.js @@ -10,15 +10,6 @@ import PropTypes from 'prop-types'; * @returns React Component */ const KeyInfo = ({ descriptor, resources }) => { - let datasetSize = 0 - if (resources) { - datasetSize = resources.length == 1 ? - (resources[0].size || 0) : - resources.reduce((accumulator, currentValue) => { - return (accumulator.size || 0) + (currentValue.size || 0) - }) - } - const formats = resources.map(item => item.format).join(', '); return ( @@ -53,7 +44,7 @@ const KeyInfo = ({ descriptor, resources }) => {

{resources.length}

-

{datasetSize}

+

{descriptor.size || 'N/A'}

{formats}