From 9c0c4dfae3618c999e2db5d3f8b600fbd47c2a41 Mon Sep 17 00:00:00 2001 From: Rufus Pollock Date: Thu, 26 Apr 2012 21:20:59 +0100 Subject: [PATCH] [#46,view-grid,view-transform-dialog][s]: switch ColumnTransform to work off bootstrap modal. --- css/grid.css | 4 ---- src/view-grid.js | 10 ++-------- src/view-transform-dialog.js | 19 ++++++++++--------- 3 files changed, 12 insertions(+), 21 deletions(-) diff --git a/css/grid.css b/css/grid.css index aeb9984e..88f0b134 100644 --- a/css/grid.css +++ b/css/grid.css @@ -210,10 +210,6 @@ div.data-table-cell-content-numeric > a.data-table-cell-edit { * Transform Dialog *********************************************************/ -#expression-preview-tabs .ui-tabs-nav li a { - padding: 0.15em 1em; -} - textarea.expression-preview-code { font-family: monospace; height: 5em; diff --git a/src/view-grid.js b/src/view-grid.js index dc616713..bafc08ae 100644 --- a/src/view-grid.js +++ b/src/view-grid.js @@ -104,19 +104,13 @@ my.Grid = Backbone.View.extend({ }, showTransformColumnDialog: function() { - var $el = $('.dialog-content'); - util.show('dialog'); var view = new my.ColumnTransform({ model: this.model }); view.state = this.tempState; view.render(); - $el.empty(); - $el.append(view.el); - util.observeExit($el, function() { - util.hide('dialog'); - }); - $('.dialog').draggable({ handle: '.dialog-header', cursor: 'move' }); + this.el.append(view.el); + view.el.modal(); }, showTransformDialog: function() { diff --git a/src/view-transform-dialog.js b/src/view-transform-dialog.js index 12f83872..c3f62d35 100644 --- a/src/view-transform-dialog.js +++ b/src/view-transform-dialog.js @@ -76,12 +76,13 @@ my.DataTransform = Backbone.View.extend({ // View (Dialog) for doing data transformations (on columns of data). my.ColumnTransform = Backbone.View.extend({ - className: 'transform-column-view', + className: 'transform-column-view modal fade in', template: ' \ -
\ - Functional transform on column {{name}} \ + \ -
\ + \ -