knight/datahub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#25,model][xs]: turns out the hack to allow simple arguments to Field ctor does *not* work.

Browse Source
This commit is contained in:
Rufus Pollock 2012-02-18 08:11:38 +00:00
parent 2da6c1a297
commit a75e04701f
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/model.js
View File

@ -96,8 +96,7 @@ my.Field = Backbone.Model.extend({
initialize: function(data) {
// if a hash not passed in the first argument is set as value for key 0
if ('0' in data) {
this.set({id: data['0']});
this.unset('0');
throw new Error('Looks like you did not pass a proper hash with id to Field constructor');
}
if (this.attributes.label == null) {
this.set({label: this.id});

9
test/model.test.js
View File

@ -13,10 +13,11 @@ test('Field: basics', function () {
});
equal(field.attributes.label, 'My label', 'Field label should be set from id but not if explicitly provided');
var field = new recline.Model.Field('x');
equal(field.id, 'x', 'Set of id from single argumentst to ctor');
equal(field.attributes.id, 'x', 'Set of id from single argumentst to ctor');
ok(!('0' in field.toJSON()), 'Should have removed artificially created 0 key in attributes');
raises(function() {
var field = new recline.Model.Field('xxx');
},
'should throw an error if not passed in a hash with id'
);
});
})(this.jQuery);