From ae8f51bf05cf0f51165b0cac2331a0028a840b77 Mon Sep 17 00:00:00 2001 From: Rufus Pollock Date: Sun, 1 Jun 2014 19:58:45 +0100 Subject: [PATCH] [#429,map,bugfix][s]: parse negative lat/lon strings correctly - fixes #429. --- src/view.map.js | 2 +- test/view.map.test.js | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/view.map.js b/src/view.map.js index a90270ce..dce77b5b 100644 --- a/src/view.map.js +++ b/src/view.map.js @@ -334,7 +334,7 @@ my.Map = Backbone.View.extend({ if (typeof(coord) != 'string') { return(parseFloat(coord)); } - var dms = coord.split(/[^\.\d\w]+/); + var dms = coord.split(/[^-?\.\d\w]+/); var deg = 0; var m = 0; var toDeg = [1, 60, 3600]; // conversion factors for Deg, min, sec var i; diff --git a/test/view.map.test.js b/test/view.map.test.js index d867410f..26b36ecb 100644 --- a/test/view.map.test.js +++ b/test/view.map.test.js @@ -112,7 +112,10 @@ test('_getGeometryFromRecord non-GeoJSON', function () { [{ lon: 47, lat: 53}, [47,53]], [{ lon: -47, lat: 53}, [-47,53]], ["53.3,47.32", [47.32, 53.3]], + ["53.3,-47.32", [-47.32, 53.3]], ["53.3, 47.32", [47.32, 53.3]], + ["-53.3, 47.32", [47.32, -53.3]], + ["53.3, -47.32", [-47.32, 53.3]], ["(53.3,47.32)", [47.32, 53.3]], [[53.3,47.32], [53.3, 47.32]], ["53.3 N, 113.5 W", [-113.5, 53.3]],