knight/datahub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#425] Fix Dataset.query() when called with Query model

Browse Source 
The problem is that Backbone >= 0.9.9 doesn't accept updating models with:

    model.set(otherModel);

That needs to be changed to:

    model.set(otherModel.attributes);

Dataset.query() accepts both regular JS objects and Query models, so we need to
check the parameter type to support both.
This commit is contained in:
Vitor Baptista 2014-05-14 15:37:17 -03:00
parent fa1e4d385c
commit b26f270ffa
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/model.js
View File

@ -191,7 +191,11 @@ my.Dataset = Backbone.Model.extend({
this.trigger('query:start');
if (queryObj) {
this.queryState.set(queryObj, {silent: true});
var attributes = queryObj;
if (queryObj instanceof my.Query) {
attributes = queryObj.toJSON();
}
this.queryState.set(attributes, {silent: true});
}
var actualQuery = this.queryState.toJSON();

25
test/model.test.js
View File

@ -177,6 +177,31 @@ test('Dataset getFieldsSummary', function () {
});
});
test('query with Query model', function () {
var dataset = new recline.Model.Dataset({
records: [{country: 'UK'}, {country: 'DE'}]
});
var query = new recline.Model.Query();
query.addFilter({type: 'term', field: 'country', term: 'DE'});
dataset.query(query).done(function (results) {
deepEqual(results.length, 1);
deepEqual(results.models[0].toJSON(), {country: 'DE'});
});
});
test('query with plain object', function () {
var dataset = new recline.Model.Dataset({
records: [{country: 'UK'}, {country: 'DE'}]
});
var query = {q: 'DE'};
dataset.query(query).done(function (results) {
deepEqual(results.length, 1);
deepEqual(results.models[0].toJSON(), {country: 'DE'});
});
});
test('fetch without and with explicit fields', function () {
var dataset = new recline.Model.Dataset({
backend: 'csv',