[view/multiview][s]: do not call fetch on dataset model in MultiView initialize (should be done in code using the view if needed).
* fetch method should have been done elsewhere (by client of the view) * calling in the view is both wasteful and causes possible bugs as it may lead to race conditions to a fetch called by client code
This commit is contained in:
@@ -228,10 +228,6 @@ my.MultiView = Backbone.View.extend({
|
|||||||
// note this.model and dataset returned are the same
|
// note this.model and dataset returned are the same
|
||||||
// TODO: set query state ...?
|
// TODO: set query state ...?
|
||||||
this.model.queryState.set(self.state.get('query'), {silent: true});
|
this.model.queryState.set(self.state.get('query'), {silent: true});
|
||||||
this.model.fetch()
|
|
||||||
.fail(function(error) {
|
|
||||||
self.notify({message: error.message, category: 'error', persist: true});
|
|
||||||
});
|
|
||||||
},
|
},
|
||||||
|
|
||||||
setReadOnly: function() {
|
setReadOnly: function() {
|
||||||
|
|||||||
Reference in New Issue
Block a user