From be67a2dad4557f4ed66541600af543859b95f4c5 Mon Sep 17 00:00:00 2001 From: Dan Wilson Date: Thu, 16 May 2013 11:34:47 +0100 Subject: [PATCH] Some more jshint cleanup. Issue #340. --- src/backend.elasticsearch.js | 4 ++-- src/backend.gdocs.js | 6 +++--- src/backend.memory.js | 14 +++++++------- src/view.flot.js | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/backend.elasticsearch.js b/src/backend.elasticsearch.js index 5d02965f..3b1343ca 100644 --- a/src/backend.elasticsearch.js +++ b/src/backend.elasticsearch.js @@ -138,7 +138,7 @@ this.recline.Backend.ElasticSearch = this.recline.Backend.ElasticSearch || {}; this._convertFilter = function(filter) { var out = {}; - out[filter.type] = {} + out[filter.type] = {}; if (filter.type === 'term') { out.term[filter.field] = filter.term.toLowerCase(); } else if (filter.type === 'geo_distance') { @@ -168,7 +168,7 @@ this.recline.Backend.ElasticSearch = this.recline.Backend.ElasticSearch || {}; dataType: this.options.dataType }); return jqxhr; - } + }; }; diff --git a/src/backend.gdocs.js b/src/backend.gdocs.js index 27eaee38..6a7145cd 100644 --- a/src/backend.gdocs.js +++ b/src/backend.gdocs.js @@ -143,14 +143,14 @@ this.recline.Backend.GDocs = this.recline.Backend.GDocs || {}; if(!!matches) { key = matches[1]; // the gid in url is 0-based and feed url is 1-based - worksheet = parseInt(matches[3]) + 1; + worksheet = parseInt(matches[3], 10) + 1; if (isNaN(worksheet)) { worksheet = 1; } urls = { worksheet : 'https://spreadsheets.google.com/feeds/list/'+ key +'/'+ worksheet +'/public/values?alt=json', spreadsheet: 'https://spreadsheets.google.com/feeds/worksheets/'+ key +'/public/basic?alt=json' - } + }; } else { // we assume that it's one of the feeds urls @@ -160,7 +160,7 @@ this.recline.Backend.GDocs = this.recline.Backend.GDocs || {}; urls = { worksheet : 'https://spreadsheets.google.com/feeds/list/'+ key +'/'+ worksheet +'/public/values?alt=json', spreadsheet: 'https://spreadsheets.google.com/feeds/worksheets/'+ key +'/public/basic?alt=json' - } + }; } return urls; diff --git a/src/backend.memory.js b/src/backend.memory.js index 897d1baf..18c5ca13 100644 --- a/src/backend.memory.js +++ b/src/backend.memory.js @@ -108,9 +108,9 @@ this.recline.Backend.Memory = this.recline.Backend.Memory || {}; integer: function (e) { return parseFloat(e, 10); }, 'float': function (e) { return parseFloat(e, 10); }, number: function (e) { return parseFloat(e, 10); }, - string : function (e) { return e.toString() }, - date : function (e) { return moment(e).valueOf() }, - datetime : function (e) { return new Date(e).valueOf() } + string : function (e) { return e.toString(); }, + date : function (e) { return moment(e).valueOf(); }, + datetime : function (e) { return new Date(e).valueOf(); } }; var keyedFields = {}; _.each(self.fields, function(field) { @@ -141,8 +141,8 @@ this.recline.Backend.Memory = this.recline.Backend.Memory || {}; } function range(record, filter) { - var startnull = (filter.start == null || filter.start === ''); - var stopnull = (filter.stop == null || filter.stop === ''); + var startnull = (filter.start === null || filter.start === ''); + var stopnull = (filter.stop === null || filter.stop === ''); var parse = getDataParser(filter); var value = parse(record[filter.field]); var start = parse(filter.start); @@ -166,8 +166,8 @@ this.recline.Backend.Memory = this.recline.Backend.Memory || {}; if (queryObj.q) { var terms = queryObj.q.split(' '); var patterns=_.map(terms, function(term) { - return new RegExp(term.toLowerCase());; - }); + return new RegExp(term.toLowerCase()); + }); results = _.filter(results, function(rawdoc) { var matches = true; _.each(patterns, function(pattern) { diff --git a/src/view.flot.js b/src/view.flot.js index ff1862d9..7bebbf93 100644 --- a/src/view.flot.js +++ b/src/view.flot.js @@ -215,7 +215,7 @@ my.Flot = Backbone.View.extend({ var numTicks = Math.min(this.model.records.length, 15); var increment = this.model.records.length / numTicks; var ticks = []; - for (i=0; i