knight/datahub
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[KeyInfo component][xs]: removed complex/buggy logic for calculating total size of all files.

Browse Source 
We still can display total size if it is available from 'descriptor.size', otherwise, we just display 'N/A'.
This is probably a good one for removal in the future as we could show sizes for each resource instead of total size.
This commit is contained in:
anuveyatsu 2021-08-14 21:07:04 +06:00
parent 04a7a59c17
commit 89e7b942aa
3 changed files with 3 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dist/index.cjs.js vendored
View File

@ -221,14 +221,6 @@ var KeyInfo = function KeyInfo(_ref) {
var descriptor = _ref.descriptor,
resources = _ref.resources;
var datasetSize = 0;
if (resources) {
datasetSize = resources.length == 1 ? resources[0].size || 0 : resources.reduce(function (accumulator, currentValue) {
return (accumulator.size || 0) + (currentValue.size || 0);
});
}
var formats = resources.map(function (item) {
return item.format;
}).join(', ');
@ -260,7 +252,7 @@ var KeyInfo = function KeyInfo(_ref) {
className: "text-1xl"
}, resources.length)), /*#__PURE__*/React__default['default'].createElement("div", null, /*#__PURE__*/React__default['default'].createElement("h3", {
className: "text-1xl"
}, datasetSize)), /*#__PURE__*/React__default['default'].createElement("div", null, /*#__PURE__*/React__default['default'].createElement("h3", {
}, descriptor.size || 'N/A')), /*#__PURE__*/React__default['default'].createElement("div", null, /*#__PURE__*/React__default['default'].createElement("h3", {
className: "text-1xl"
}, formats)), /*#__PURE__*/React__default['default'].createElement("div", null, /*#__PURE__*/React__default['default'].createElement("h3", {
className: "text-1xl"

10
dist/index.esm.js vendored
View File

@ -187,14 +187,6 @@ var KeyInfo = function KeyInfo(_ref) {
var descriptor = _ref.descriptor,
resources = _ref.resources;
var datasetSize = 0;
if (resources) {
datasetSize = resources.length == 1 ? resources[0].size || 0 : resources.reduce(function (accumulator, currentValue) {
return (accumulator.size || 0) + (currentValue.size || 0);
});
}
var formats = resources.map(function (item) {
return item.format;
}).join(', ');
@ -226,7 +218,7 @@ var KeyInfo = function KeyInfo(_ref) {
className: "text-1xl"
}, resources.length)), /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("h3", {
className: "text-1xl"
}, datasetSize)), /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("h3", {
}, descriptor.size || 'N/A')), /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("h3", {
className: "text-1xl"
}, formats)), /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("h3", {
className: "text-1xl"

11
src/components/dataset/KeyInfo.js
View File

@ -10,15 +10,6 @@ import PropTypes from 'prop-types';
* @returns React Component
*/
const KeyInfo = ({ descriptor, resources }) => {
let datasetSize = 0
if (resources) {
datasetSize = resources.length == 1 ?
(resources[0].size || 0) :
resources.reduce((accumulator, currentValue) => {
return (accumulator.size || 0) + (currentValue.size || 0)
})
}
const formats = resources.map(item => item.format).join(', ');
return (
@ -53,7 +44,7 @@ const KeyInfo = ({ descriptor, resources }) => {
<h3 className="text-1xl">{resources.length}</h3>
</div>
<div>
<h3 className="text-1xl">{datasetSize}</h3>
<h3 className="text-1xl">{descriptor.size || 'N/A'}</h3>
</div>
<div>
<h3 className="text-1xl">{formats}</h3>